Airbyte apis#20
Merged
Merged
Conversation
illicitonion
reviewed
Oct 6, 2025
Member
illicitonion
left a comment
illicitonion
left a comment
There was a problem hiding this comment.
This looks good, thanks! I left a few comments around simplifying a few things which will hopefully make Clippy happier too :)
illicitonion
reviewed
Oct 7, 2025
Member
illicitonion
left a comment
illicitonion
left a comment
There was a problem hiding this comment.
Looking good! A couple more things to ponder, and I think we're good to go!
illicitonion
reviewed
Oct 8, 2025
illicitonion
reviewed
Oct 8, 2025
Member
illicitonion
left a comment
illicitonion
left a comment
There was a problem hiding this comment.
LGTM - happy to merge when the config.prod.json is reverted :) Thanks!
illicitonion
approved these changes
Oct 10, 2025
Member
illicitonion
left a comment
illicitonion
left a comment
There was a problem hiding this comment.
LGTM! Please fmt and we can merge!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR has endpoint with returns trainees attendance per sprint/modul/batch/course